Handle undefined links in reader view

Also added check to ignore "root" url trailing slash
msasikanth · Feb 15, 2024 · 86d852e · 86d852e
1 parent eeb3d96
commit 86d852e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/shared/src/commonMain/kotlin/dev/sasikanth/rss/reader/reader/ui/ReaderHTML.kt b/shared/src/commonMain/kotlin/dev/sasikanth/rss/reader/reader/ui/ReaderHTML.kt
@@ -120,7 +120,10 @@ private object ReaderJs {
     function handleLinkClick(event) {
         try {
           event.preventDefault();
-          let href = findHref(event.target);
+          var href = findHref(event.target);
+          if (href == undefined || href == "/") {
+            href = ""
+          }
           window.kmpJsBridge.callNative(
             "linkHandler", 
             href, 

diff --git a/shared/src/commonMain/kotlin/dev/sasikanth/rss/reader/reader/ui/ReaderLinkHandler.kt b/shared/src/commonMain/kotlin/dev/sasikanth/rss/reader/reader/ui/ReaderLinkHandler.kt
@@ -27,7 +27,9 @@ class ReaderLinkHandler(private val openLink: (String) -> Unit) : IJsMessageHand
     navigator: WebViewNavigator?,
     callback: (String) -> Unit
   ) {
-    openLink(message.params)
+    if (message.params.isNotBlank()) {
+      openLink(message.params)
+    }
   }
 
   override fun methodName(): String {