Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add decorators for FastAPI as well #19

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

ocervell
Copy link
Contributor

Sorry I didn't see that you asked me to review #17.

It is not uncommon in FastAPI to not use the Depends(Security) schema and instead build auth with the old methods used e.g in Flask, using good old decorators.

This PR makes it easy to detect authenticated decorated routes.

@mschwager
Copy link
Owner

If you rebase on master (8d8f521), then CI should be working again 👍

@mschwager mschwager self-requested a review April 24, 2024 13:51
Copy link
Owner

@mschwager mschwager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the help!

@mschwager mschwager merged commit 982d880 into mschwager:main Apr 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants