Skip to content

Commit

Permalink
graalvm.yml: Use setup_java GitHub Action
Browse files Browse the repository at this point in the history
We can now use the same setup_java GitHub Action
in gradle.yml and graalvm.yml. This commit switches
to the setup_java action from the setup-graalvm action
and also changes some variable names to more closely
match gradle.yml.

The setup_java Action at this time only supports _Oracle_ GraalVM which
is licensed under the GFTC license:
https://www.oracle.com/downloads/licenses/graal-free-license.html

See: actions/setup-java#742

So the benefits of using the same action for JDK and GraalVM
have to be weighed against using only a non-FOSS version of GraalVM.

Oracle GraalVM has stopped providing updates under the free-beer license
for JDK 17, so I removed `17` from the matrix. It is also possible
to use the last version: `17.0.12`

The setup_graalvm action supports the Community Edition, Oracle GraalVM,
and some other options.

(It might even be possible/desirable to combine the
two workflows in the future, but let's keep this PR simple)
  • Loading branch information
msgilligan committed Feb 1, 2025
1 parent 31be6f5 commit ba1f7fb
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions .github/workflows/graalvm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,19 @@ jobs:
strategy:
matrix:
os: [ubuntu-24.04, macOS-13]
java-version: [ '17', '21' ]
distribution: [ 'graalvm-community' ]
java: [ '21' ]
distribution: [ 'graalvm' ]
gradle: ['8.12.1']
fail-fast: false
name: ${{ matrix.os }} JDK ${{ matrix.java-version }}.${{ matrix.distribution }}
name: ${{ matrix.os }} JDK ${{ matrix.java }}.${{ matrix.distribution }}
steps:
- name: Git checkout
uses: actions/checkout@v4
- name: Set up GraalVM
uses: graalvm/setup-graalvm@v1
- name: Set up JDK (GraalVM)
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java-version }}
distribution: ${{ matrix.distribution }}
github-token: ${{ secrets.GITHUB_TOKEN }}
java-version: ${{ matrix.java }}
- name: Set up Gradle
uses: gradle/actions/setup-gradle@v3
with:
Expand All @@ -32,5 +31,5 @@ jobs:
- name: Upload wallet-tool as artifact
uses: actions/upload-artifact@v4
with:
name: wallet-tool-${{ matrix.os }}-${{ matrix.java-version }}
name: wallet-tool-${{ matrix.os }}-${{ matrix.java }}
path: wallettool/build/native/nativeCompile/wallet-tool

0 comments on commit ba1f7fb

Please sign in to comment.