Skip to content

Commit

Permalink
[CH] Support expm1 function (apache#5422)
Browse files Browse the repository at this point in the history
What changes were proposed in this pull request?
How was this patch tested?
Pass CI
  • Loading branch information
exmy authored Apr 18, 2024
1 parent 65dd411 commit 42a103b
Show file tree
Hide file tree
Showing 5 changed files with 61 additions and 2 deletions.
59 changes: 59 additions & 0 deletions cpp-ch/local-engine/Parser/scalar_function_parser/expm1.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#include <Parser/FunctionParser.h>

namespace DB
{
namespace ErrorCodes
{
extern const int NUMBER_OF_ARGUMENTS_DOESNT_MATCH;
}
}

namespace local_engine
{
class FunctionParserExpm1 : public FunctionParser
{
public:
explicit FunctionParserExpm1(SerializedPlanParser * plan_parser_) : FunctionParser(plan_parser_) {}
~FunctionParserExpm1() override = default;

static constexpr auto name = "expm1";

String getName() const override { return name; }

const ActionsDAG::Node * parse(
const substrait::Expression_ScalarFunction & substrait_func,
ActionsDAGPtr & actions_dag) const override
{
/// parse expm1(x) as exp(x) - 1
auto parsed_args = parseFunctionArguments(substrait_func, "", actions_dag);
if (parsed_args.size() != 1)
throw Exception(ErrorCodes::NUMBER_OF_ARGUMENTS_DOESNT_MATCH, "Function {} requires exactly one arguments", getName());

const auto * x_node = parsed_args[0];
const auto * exp_node = toFunctionNode(actions_dag, "exp", {x_node});
const auto * one_const_node = addColumnToActionsDAG(actions_dag, std::make_shared<DataTypeFloat64>(), 1.0);
const auto * result_node = toFunctionNode(actions_dag, "minus", {exp_node, one_const_node});

return convertNodeTypeIfNeeded(substrait_func, result_node, actions_dag);
}
};

static FunctionParserRegister<FunctionParserExpm1> register_expm1;
}
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ object ExpressionMappings {
Sig[Ceil](CEIL),
Sig[Floor](FLOOR),
Sig[Exp](EXP),
Sig[Expm1](EXPM1),
Sig[Pow](POWER),
Sig[Pmod](PMOD),
Sig[Round](ROUND),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,6 @@ class ClickHouseTestSettings extends BackendTestSettings {
enableSuite[GlutenMathExpressionsSuite]
.exclude("tanh")
.exclude("rint")
.exclude("expm1")
.exclude("unhex")
.exclude("atan2")
.exclude("round/bround")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,6 @@ class ClickHouseTestSettings extends BackendTestSettings {
enableSuite[GlutenMathExpressionsSuite]
.exclude("tanh")
.exclude("rint")
.exclude("expm1")
.exclude("unhex")
.exclude("atan2")
.exclude("round/bround/floor/ceil")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ object ExpressionNames {
final val CEIL = "ceil"
final val FLOOR = "floor"
final val EXP = "exp"
final val EXPM1 = "expm1"
final val POWER = "power"
final val PMOD = "pmod"
final val ROUND = "round"
Expand Down

0 comments on commit 42a103b

Please sign in to comment.