Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom/splitfastqbylane module #23

Merged

Conversation

anoronh4
Copy link
Collaborator

@anoronh4 anoronh4 commented Jan 9, 2024

PR checklist

Addresses #13

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • nf-test test --profile=docker --tag
    • nf-test test --profile=singularity --tag
    • nf-test test --profile=conda --tag

@anoronh4
Copy link
Collaborator Author

i need to fix conda weirdness here but the logic of the process should be accurate.

@anoronh4 anoronh4 marked this pull request as ready for review January 16, 2024 16:39
@anoronh4
Copy link
Collaborator Author

conda issues have been fixed, everything seems to be passing tests now!

@anoronh4 anoronh4 requested a review from nikhil January 17, 2024 16:51
Copy link
Collaborator

@buehlere buehlere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I made a few minor comments to consider, but I think this is good as is.

tests/config/nf-test.config Show resolved Hide resolved
modules/msk/custom/splitfastqbylane/main.nf Outdated Show resolved Hide resolved
Copy link
Collaborator

@buehlere buehlere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@anoronh4 anoronh4 merged commit bb97dd8 into mskcc-omics-workflows:develop Jan 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants