Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maf2vcf.pl: multiple FILTER tags should be semicolon separated #209

Open
soccin opened this issue Dec 30, 2018 · 2 comments
Open

maf2vcf.pl: multiple FILTER tags should be semicolon separated #209

soccin opened this issue Dec 30, 2018 · 2 comments
Assignees

Comments

@soccin
Copy link

soccin commented Dec 30, 2018

The VCF spec (https://github.com/samtools/hts-specs/blob/master/VCFv4.3.tex) says:

FILTER - filter status: PASS if this position has passed all filters, i.e. a call is made at this position. Otherwise, if the site has not passed all filters, a semicolon-separated list of codes for filters that fail. e.g. “q10;s50”

Some VCF parsers are fussy about this; simple fix:

@@ -196,6 +196,9 @@ while( my $line = $maf_fh->getline ) {
     $qual = "." if( !defined $qual or $qual eq "" );
     $filter = "." if( !defined $filter or $filter eq "" );
 
+    # VCF Spec says multiple FILTER tags should be _semicolon_ separated
+    $filter =~ s/,/;/g;
+
     # If normal alleles are unset in the MAF (quite common), assume homozygous reference
     $n_al1 = $ref if( $n_al1 eq "" );
     $n_al2 = $ref if( $n_al2 eq "" );
@ckandoth ckandoth self-assigned this Jan 2, 2019
@ckandoth
Copy link
Collaborator

ckandoth commented Jan 2, 2019

Thanks @soccin - I switched from comma to semicolon in release v1.6.14, but this looks like an unhandled exception when the input MAF uses commas, and is copied unchanged. I'll put a fix in the backlog, but let me know if you need a fix ASAP.

@soccin
Copy link
Author

soccin commented Jan 2, 2019

Not urgent. I have a local version I fixed for now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants