dts: msm8952: Add support for Motorola Moto G6 Play (XT1922-9, "jeter") #464
Conversation
| gpios = <&pmic_pon GPIO_PMIC_RESIN 0>; | ||
| }; | ||
| }; | ||
|
|
andrewgigena
force-pushed
the
msm8920-motorola-jeter
branch
from
0f46ba0 to
fa3f72b
Compare
andrewgigena
force-pushed
the
msm8920-motorola-jeter
branch
from
fa3f72b to
905ced4
Compare
|
I have unchecked the draft option, so the PR is now ready to merge following the reviews. I have implemented the changes you suggested, and @pryzhak has tested it thoroughly. Everything appears to be functioning correctly across all menu options. However, the recovery option is still buggy—it returns to lk2nd instead of entering recovery mode as expected. We verified the regulators, and the SD card's LDO11 is enabled, allowing booting from it (although this has not been tested). The buttons are functioning as intended. Regarding the next v21, do you know if there are plans to autobuild for these devices? I am concerned it might not boot on his device due to the signing and single DTB option. |
There was a problem hiding this comment.
Regarding the next v21, do you know if there are plans to autobuild for these devices? I am concerned it might not boot on his device due to the signing and single DTB option.
For those cases my ""policy"" is to let the user to build quirky devices. Unfortunately, if you look at the devices.md file and the amount of "quirky" notes, if we were to build a custom image for each of those, it would be even bigger nightmare than letting user to run a command on their own.
Considering the thing was added without the quirky note, perhaps there is some configuration in which signing/single dtb is not needed? Could you confirm again that it doesn't boot with either signing or single-dtb disabled?
| /* | ||
| * model is required by bootloader to pick dtb. | ||
| * The bootloader also crashes if model isn't present in every dtb. (see lk2nd.dtsi for more info) | ||
| * Build with: make TOOLCHAIN_PREFIX=arm-none-eabi- SIGN_BOOTIMG=1 LK2ND_ADTBS="msm8920-motorola-jeter.dtb" LK2ND_DTBS="" lk2nd-msm8952 |
There was a problem hiding this comment.
Can you also update the devices.md file to note this one is quirky?
Hello everyone, this pull request introduces device tree support for the Motorola Moto G6 Play (codenamed "jeter") on the MSM8952 platform, which utilizes the MSM8920 CPU (Snapdragon 427).
The DTS was handwritten based on downstream DTS extracted from unofficial TWRP images found on XDA and the official TWRP of G6 (non-play variant). Its functionality was tested and verified by @pryzhak, the device owner, via the Matrix community. The
gpio-keyswere explicitly set exactly as the downstream DTS, maybe we can strip down "down" and "power" keys after some more testing with @pryzhak.Build command (needs bootsignature.py dependencies installed):
Below is a reference image for the device:
