Skip to content

ARM: dts: qcom-msm8974pro-oneplus-bacon: Add NFC node #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: qcom-msm8974-6.9.y
Choose a base branch
from
Open

ARM: dts: qcom-msm8974pro-oneplus-bacon: Add NFC node #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions arch/arm/boot/dts/qcom/qcom-msm8974pro-oneplus-bacon.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,16 @@
interrupts-extended = <&tlmm 31 IRQ_TYPE_EDGE_FALLING>;
omit-battery-class;
};

nfc@28 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move this node above the charger since 0x28 < 0x6b

compatible = "nxp,nxp-nci-i2c";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have any clue what actual NFC chipset is in the phone? Some number like NQ310 or PN547?

Copy link
Author

@rhjdvsgsgks rhjdvsgsgks Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on downstream kernel it says "pn544". but i cant use it with "nxp,pn544-i2c" driver

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep it like this then. Maybe we can find an ID register on the chip that give us some better idea but it's not really important

reg = <0x28>;

interrupts-extended = <&tlmm 59 IRQ_TYPE_EDGE_FALLING>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other devices in mainline seem to use either IRQ_TYPE_EDGE_RISING or IRQ_TYPE_LEVEL_HIGH, so I'm inclined to think IRQ_TYPE_EDGE_FALLING is not very correct

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. i observed some

power_supply bq27541-0: driver failed to report `capacity' property: -6
bq27xxx-battery 0-0055: error reading current

for the charger on same bus which also using IRQ_TYPE_EDGE_FALLING. i will test IRQ_TYPE_EDGE_RISING and IRQ_TYPE_LEVEL_HIGH to see can they have a better stability

Copy link
Author

@rhjdvsgsgks rhjdvsgsgks Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can confirm rmi4-i2c-dev on downstream are using IRQ_TYPE_EDGE_FALLING. but i didnt find anything about bq24196_charger's irq pin (and its config) on downstream. do you know where is it come from?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should the touchscreen (rmi4) and charger (bq....) have to do with the nfc chip? I don't quite get why you look at those right now.


enable-gpios = <&tlmm 14 GPIO_ACTIVE_HIGH>;
firmware-gpios = <&tlmm 13 GPIO_ACTIVE_HIGH>;
};
};

&blsp1_uart2 {
Expand Down