feat: add net.Socket-based interceptor #375
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proof of concept of a Socket-based interceptor.
Things I learned
net.createConnection()
accepts alookup
function that we can use to resolve non-existing hosts to whatever we want. It won't automatically give us a successful connection (because that's done bysocket._handler.connect()
) but it will prevent DNS lookup issues.net.creaetConnection()
accepts a customhandler
class instance. It's an internal API responsible for provisioning the connection to a resolved address, reading/writing socket chunks, and terminating the socket.Links
Roadmap
./socket.impl
after you importhttp
, it stops working.connect
andready
events. This will improve the underlying code's integrity and allow us to replay the connection errors (very similar to what we already do inClientRequestInterceptor
).Unsupported fd type: UNKNOWN
fromcreateHandle
).Interceptor
(class SocketInterceptor extends Interceptor
).