Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(http): add "connect" and "secureConnect" tests #576

Merged
merged 1 commit into from
Jun 7, 2024
Merged

test(http): add "connect" and "secureConnect" tests #576

merged 1 commit into from
Jun 7, 2024

Conversation

kettanaito
Copy link
Member

@kettanaito kettanaito commented Jun 1, 2024 •
edited
Loading

@kettanaito
Copy link
Member Author

Hi, @mikicho. Could you please take a brief look at these tests? They confirm that the Socket interceptor correctly emits the connect and secureConnect events for both mocked and bypassed scenarios. Thanks!

@kettanaito kettanaito requested a review from mikicho June 1, 2024 15:14
@mikicho
Copy link
Contributor

mikicho commented Jun 7, 2024 •
edited
Loading

Looks great!
The tests in Nock fail due to #515 (comment), which we can tackle later. my bad

@kettanaito kettanaito merged commit 7ab764e into feat/yet-another-socket-interceptor Jun 7, 2024
2 checks passed
@kettanaito kettanaito deleted the fix/http-connect-event branch June 7, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikicho mikicho Awaiting requested review from mikicho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kettanaito @mikicho