chore: use vitest for type testing #2033
Conversation
|
Hey @kettanaito, I have made a first stab at this. Would it be possible for you to approve the workflow run so I can see if what I have done for the vitest config RE typescript versions is even remotely correct :D |
kettanaito
changed the title
| globals: true, | ||
| typecheck: { | ||
| checker: 'tsc', | ||
| tsconfig: (() => { |
| @@ -28,6 +28,6 @@ export default defineConfig({ | |||
| * If any tests attempt to run during that window, | |||
| * they will fail, unable to resolve the "msw" import alias. | |||
| */ | |||
| singleThread: true, | |||
| poolOptions: { threads: { singleThread: true } }, | |||
There was a problem hiding this comment.
👍 Good catch. I'm also considering moving away from this. We need this due to a single test packing the library. I want to introduce a new level of testing (that does the packing) and run it separately from the other tests. By doing so, we will finally be able to run Vitest in a watch mode, and also use multiple threads for the rest of the tests.
There was a problem hiding this comment.
That sounds great, yeah this was needed with the vitest upgrade
|
@KaiSpencer, looks like some of your changes were reflected in the |
I have done this and committed the lockfile, so should be good to go again on CI now |
|
Hey @kettanaito It seems the response.url is returning back as an empty string. Not quite sure why :D Any ideas? |
|
@KaiSpencer, that's an unrelated issue (I think #2031). |
|
You, sir, are incredible. Thank you for making this happen and welcome to contributors, @KaiSpencer 👏 |
Thank you for the support throughout this, It was a nice Issue/PR to get my foot in the door 🙇♂️ |
|
If you see any other tasks that interest you, don't hesitate to leave a comment! |
|
I'll take a look 👀 |
Released: v2.2.10 🎉This has been released in v2.2.10! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
closes #2019