fix: support SharedArrayBuffer in HttpResponse.arrayBuffer
#2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
changed the title
SharedArrayBuffer in HttpResponse.arrayBuffer
kettanaito
approved these changes
Dec 14, 2024
There was a problem hiding this comment.
This looks great! Thank you so much for fixing this, @danilofuchs 👏
|
The Node.js tests are failing to unrelated reasons (see #2386). I'd love to fix that one first before merging this one so we get clean test runs. |
|
Thanks once again for shipping this, @danilofuchs. Welcome to contributors! 🎉 |
Released: v2.6.9 🎉This has been released in v2.6.9! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
|
Happy to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2388
I've added support for using
SharedArrayBufferas an argument toHttpResponse.arrayBuffer()This is necessary as in Typescript 5.7 with lib ES2024,
Bufferis no longer assignable to simplyArrayBufferWhen testing this, the default content type was being
text/plain;charset=utf-8I'm not sure if I did the right thing by setting the default to
application/octet-stream(this is the only method without a default)