SAMLAuth::getValuesWithRule() method bug fixed.

msyk · Jun 19, 2024 · 782758c · 782758c
1 parent 67a7319
commit 782758c
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/php/SAMLAuth.php b/src/php/SAMLAuth.php
@@ -121,17 +121,19 @@ private function getValuesWithRule($rule): string
     {
         $returnValue = null;
         $attributes = $this->authSimple->getAttributes();
-        $comps = explode('|', $rule);
         if (is_array($rule)) {
             $returnValue = '';
             foreach ($rule as $item) {
                 $returnValue = ((strlen($returnValue) > 0) ? ' ' : '') . $returnValue;
                 $returnValue .= $this->getValuesWithRule($item);
             }
-        } else if (isset($attributes[$comps[0]][$comps[1]]) && count($comps) === 2) {
-            $returnValue = $attributes[$comps[0]][$comps[1]];
-        } else if (isset($attributes[$rule])) {
-            $returnValue = $attributes[$rule];
+        } else {
+            $comps = explode('|', $rule);
+            if (isset($attributes[$comps[0]][$comps[1]]) && count($comps) === 2) {
+                $returnValue = $attributes[$comps[0]][$comps[1]];
+            } else if (isset($attributes[$rule])) {
+                $returnValue = $attributes[$rule];
+            }
         }
         if (is_null($returnValue)) {
             Logger::getInstance()->setWarningMessage('You have to set up the variable $samlAttrRules in params.php'