Fix SOABI
#120
Fix SOABI
#120
Conversation
|
I remember wheel only allowing certain abi tags: https://github.com/pypa/wheel/blob/3f8bdf1eb67ead22b857445c7c9aa4751ea6bd9a/src/wheel/bdist_wheel.py#L311 Not sure if this breaks it |
|
Not sure whether we should change it or not :( |
|
Maybe I should patch CMake instead? |
as long as we can build a wheel and install it, we should be fine |
|
On Linux I see where the file extension is not included in SOABI. And FWIW, a running mingw64 cpython (that can import dynamic libs) shows completely different values for SOABI and EXT_SUFFIX ... |
| @@ -225,6 +225,7 @@ def test_platform_things(self): | |||
| self.assertEqual(platform.python_implementation(), "CPython") | |||
| self.assertEqual(platform.system(), "Windows") | |||
| self.assertTrue(isinstance(sys.api_version, int) and sys.api_version > 0) | |||
| self.assertEqual(sysconfig.get_config_var('SOABI'), sysconfig.get_config_var('EXT_SUFFIX')) | |||
There was a problem hiding this comment.
This test should be fixed EXT_SUFFIX=SOABI+sharedl library extension
|
Maybe make it part of Python #165 |
I'm kinda hesitant to change this since there's a possibility that we won't be able to build and install wheels. I'll first test it out thoroughly and only then make this change. I'll not include it in the original PR though in another new one so we can track it a bit more easily. Though we can get it all out together in the repo. I'll also add this to #167 |
Fixes #119
Not sure if this will break anything else, cc @lazka