Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nano: follow git-for-windows and paint interface elements #5224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luau-project
Copy link
Contributor

Description

As the title says: follow git-for-windows and paint interface elements of nano

https://github.com/git-for-windows/git-sdk-64/blob/869fd0088bed870075a3a8e109367c0920625b57/etc/nanorc#L219-L233

Note

I did not use the same colors as git-for-windows to differentiate the MSYS2 shells. The titlecolor was set as magenta (resembles MSYS2 icon color), and orange / yellow on other parts to resemble the recommended environment (UCRT64) icon color.

Screenshots

Once this PR is merged, a file opened on nano through any MSYS2 shell would look like the following image

Screenshot from 2025-02-21 11-58-12

Wishes

In my opinion, MSYS2 should go even further enabling the default syntax highlighting files by uncommenting the line 252

@Biswa96
Copy link
Member

Biswa96 commented Feb 21, 2025

Software distributions should not modify user configured options except when it causes issue with the basic use case.

@luau-project
Copy link
Contributor Author

Software distributions should not modify user configured options except when it causes issue with the basic use case.

The proposed changes do not modify any user configured options. As far as I know, user configured options for nano goes on ~/.nanorc. Any option set on ~/.nanorc will take precedence over the default settings on /etc/nanorc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants