Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanitize url before sending #22

Closed
wants to merge 2 commits into from
Closed

sanitize url before sending #22

wants to merge 2 commits into from

Conversation

BuckarooBanzay
Copy link
Member

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Jun 22, 2021
@OgelGames
Copy link
Contributor

OgelGames commented Jun 22, 2021 •
edited
Loading

It really should check for more than just single spaces, that's why I put it in #2, "to do later" 😄

pandorabox-io/pandorabox.io#539 (comment)

@OgelGames OgelGames added the WIP label Jun 22, 2021
@OgelGames OgelGames removed the WIP label Jun 22, 2021
@OgelGames
Copy link
Contributor

Hmm... now that I think of it, does this even need to exist? I have not been able to reproduce a crash even without any sanitization... 🤔

(and my past self found the same thing: pandorabox-io/pandorabox.io#539 (comment))

@OgelGames
Copy link
Contributor

OgelGames commented Jun 22, 2021 •
edited
Loading

Not possible to produce a crash with unsafe characters in the URL, the http api handles it as it should, returning code 400 or 0.

Closed the issue as "mysterious but not reproducible", going to close this too.

@OgelGames OgelGames closed this Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BuckarooBanzay @OgelGames