Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder registrations of aliases and dyes #72

Merged
merged 1 commit into from
May 23, 2024

Conversation

monk-afk
Copy link
Contributor

Registrations of aliases have been moved above the craft registrations, this fixes the missing light recipes in mtg/sfinv

Registration of dyes have been moved also above the craft registration, this fixes the presentation of available recipes to show the base craft item first.

…registration of dye recipes to show item craft first before recipe craft
@BuckarooBanzay BuckarooBanzay requested a review from wsor4035 May 23, 2024 05:17
Copy link
Collaborator

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

could argue that the aliases should be moved to there own file, given this init is a couple thousand lines, but seems more apt for a refactor pr

@wsor4035 wsor4035 merged commit d0ab9b8 into mt-mods:master May 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants