Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for async rejected promise #4

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

add test for async rejected promise #4

wants to merge 1 commit into from

Conversation

BuckarooBanzay
Copy link
Member

No description provided.

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Sep 16, 2024
Niklp09
Niklp09 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@Niklp09 Niklp09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thank you.

@Niklp09
Copy link
Member

Niklp09 commented Oct 14, 2024

@BuckarooBanzay luacheck fails due to a whitespace warning.
The unittest ci seems to get stuck and then killed by gh after 6(sic) hours.

@BuckarooBanzay
Copy link
Member Author

haven't really bothered with cleaning up for luacheck yet, i still have some issues to iron out with the error propagation (hence the draft status 😉 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Niklp09 Niklp09 Niklp09 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BuckarooBanzay @Niklp09