Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort materials lists by field names #35

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

SwissalpS
Copy link
Contributor

am I the only one that is annoyed by unalphabetical lists?

@Kazooo100
Copy link
Contributor

Personally I think category would be more useful as names are subjective/variable.
For example, say I was making a mod using birch/aspen or oak/apple different games call it different things with category I know its going to be woodstuff with alphabet I don't know where to look for it, under a or b/o?

@SwissalpS
Copy link
Contributor Author

yes, initially you may not know. But once you've figured out its 'woodstuff' then you'll see the other 'woods' next to it.

@SwissalpS
Copy link
Contributor Author

currently it's not so much a category based sorting either. It has more to do with dev-history :D

@SwissalpS
Copy link
Contributor Author

it's also a bit unfortunate that 'water_bucket' isn't called 'bucket_water' so it would naturally be under 'bucket'

@Kazooo100
Copy link
Contributor

Currently ya its unorganised.

I think instead of making alphabetical we should make it categorical, then semi alphabetical.
This would also help with things like gravel/flint, they belong together but arent named that same usually.

like:

--buckets/liquids
empty_bucket = "mcl_buckets:bucket_empty",
water_bucket = "mcl_buckets:bucket:bucket_water",
water_flowing = "mcl_core:water_flowing",
water_source = "mcl_core:water_source",

--woodstuffs
apple_leaves = "mcl_trees:leaves_oak",
apple_log = "mcl_trees:tree_oak",
apple_planks = "mcl_trees:wood_oak",
slab_wood = "mcl_stairs:slab_wood", --this is apple/oak so should be near apple/oak?
birch_leaves = "mcl_trees:leaves_birch",
birch_log = "mcl_trees:tree_birch",
birch_planks = "mcl_trees:wood_birch",
jungle_leaves = "mcl_trees:leaves_jungle",

--dyes alphabetical
dye_black = "mcl_dyes:black",
dye_blue = "mcl_dyes:blue",
dye_brown = "mcl_dyes:brown",
dye_cyan = "mcl_dyes:cyan",
dye_dark_green = "mcl_dyes:dark_green",
dye_dark_grey = "mcl_dyes:dark_grey",
dye_green = "mcl_dyes:green",
dye_grey = "mcl_dyes:grey",
dye_orange = "mcl_dyes:orange",
dye_pink = "mcl_dyes:pink",
dye_red = "mcl_dyes:red",
dye_violet = "mcl_dyes:violet",
dye_white = "mcl_dyes:white",
dye_yellow = "mcl_dyes:yellow",

--axes

--hoes

---picks

--shovels

--swords

@SwissalpS
Copy link
Contributor Author

SwissalpS commented Jul 20, 2024

I prefer straightup alphabetical.
Your category approach is certainly better than what it is now.
There may be troubles with categories, as some items may make sense in multiple categories. So devs would still have to use the search function to find things.

Of course if neither the fieldname nor the category is known to dev, he has to search.
IMO chances are greater that a dev would know the fieldname or at least have an idea and so alphabetical would be more useful.

@wsor4035
Copy link
Contributor

wsor4035 commented Jul 20, 2024

I dont particularly care all that much, but I do think Kazooo's idea is pretty good. one could even argue that made materials should be grouped more like textures

@SwissalpS SwissalpS marked this pull request as draft July 20, 2024 18:32
@Kazooo100
Copy link
Contributor

I don't particularly care all that much, but I do think Kazooo's idea is pretty good. one could even argue that made materials should be grouped more like textures

made materials?

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants