Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add moreores and technic support for mineclone* games #44

Merged
merged 1 commit into from
Sep 23, 2024
Merged

add moreores and technic support for mineclone* games #44

merged 1 commit into from
Sep 23, 2024

Conversation

programmerjake
Copy link
Contributor

Fixes: #42

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Sep 23, 2024
BuckarooBanzay
BuckarooBanzay approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@BuckarooBanzay BuckarooBanzay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@programmerjake
Copy link
Contributor Author

the CI failure looks unrelated (latest master commit failed the same way), so imo this is ready to be merged

@BuckarooBanzay
Copy link
Member

the CI failure looks unrelated (latest master commit failed the same way), so imo this is ready to be merged

yeah, those are somehow related to a translation+recipe-check issue, not sure how to fix that yet

There's also this:

Nodes not present and not available in an alias/lbm:
 - 'mcl_trees:sapling_bamboo'

that's because of this: https://codeberg.org/mineclonia/mineclonia/commit/172f1a833c8c4674354b2c91d6368111a5b9b579 not an issue of this PR

@wsor4035 wsor4035 merged commit 3729628 into mt-mods:master Sep 23, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BuckarooBanzay BuckarooBanzay BuckarooBanzay approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request game(mineclone2) game(mineclonia)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

moreores and technic should be handled for mineclone* games
3 participants
@programmerjake @BuckarooBanzay @wsor4035