Moved highscores from worldpath to modstorage

[Coding-Hare]

worldpath is deprecated move it to modstorage instead.

[S-S-X]

count doesn't do anything useful after first write, you probably meant to reset it here to write every 5 minutes?

Suggested change

	if count >= 5 then
	write_file(xp_redo.highscore)
	end
	if count >= 5 then
	write_file(xp_redo.highscore)
	count = 0
	end

[Coding-Hare]

ups emberassing that I forgot this but yeah I meant that

[S-S-X]

luacheck:

    highscore.lua:4:37: line contains trailing whitespace
    highscore.lua:9:1: line contains only whitespace
    highscore.lua:17:33: line contains trailing whitespace
    highscore.lua:19:9: line contains trailing whitespace

[S-S-X]

I guess some ppl might be using highscore.txt directly, possibly publishing it to some web service or something like that.

IMO things like this shouldn't affect mod storage decisions. For stability API (or possibly globals) + separate mod should be used instead but thought that I'll mention it if someone reading this finds this causing trouble with their methods.

[wsor4035]

@Coding-Hare any plans to continue this?

[fluxionary]

worldpath is deprecated

i'm generally very much in favor of using mod storage over custom data files (w/ exceptions for e.g. the data has a complicated structure). but is the worldpath deprecated? the docs currently describe minetest.get_worldpath() as "Useful for storing custom data", and i don't see any mention of it being deprecated anywhere. this would have drastic implications for mods like sban and verbana which have their own sqlite database backends.

I guess some ppl might be using highscore.txt directly, possibly publishing it to some web service or something like that.

your-land currently does that, but sucking the data out of mod storage isn't meaningfully harder than reading a flat file.