文字を持たない変換候補をもつエントリでのクラッシュの解消・不正ではないエントリ扱いにする #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtgto
commented
Oct 26, 2024
| } | ||
|
|
||
|
|
||
| if wordsText.isEmpty { |
There was a problem hiding this comment.
上にこのブロックと同じコードがあり、上のコードはかならずreturnしているためこの行が実行されることがなかった
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#233 次のようなSKK辞書のエントリで、ddskkと異なる挙動をしています。
またバグによりクラッシュするようなエントリがあることもわかりました。
よみ //よみ /;/よみ /;注釈/ddskkに合わせて空文字列に変換できるかどうかは確認が必要なため、このPRでは次のように修正します。
よみ //よみ /;/よみ /;注釈/上記以外、例えばスラッシュで終わらない行などはこれまでと同様に不正な行として扱います。