Fix load_context_module triggering unreachable!() #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adri326
force-pushed
the
fix-load-context-unreachable
branch
from
279c2a6 to
0f1d816
Compare
triska
reviewed
Jan 7, 2025
adri326
added a commit
to adri326/scryer-prolog
that referenced
this pull request
Jan 7, 2025
adri326
force-pushed
the
fix-load-context-unreachable
branch
from
0f1d816 to
fad3ecd
Compare
|
This looks good, thank you a lot! |
|
Rebasing to master, since this is where I need this PR first for #2738 |
adri326
force-pushed
the
fix-load-context-unreachable
branch
from
fad3ecd to
eff094c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading a file with the following triggers a panic, caused by
Machine::load_context_modulecallingMachine::unify_atomwith un-derefedVars:This changes the code in
dispatch.rsto first dereference the register before callingload_context_module.