Use logger in get_static_renderers for logging

mtigas · Mar 6, 2014 · d1b8252 · d1b8252
1 parent d154614
commit d1b8252
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 19 deletions.
diff --git a/django_medusa/log.py b/django_medusa/log.py
@@ -1,6 +1,14 @@
 from django.conf import settings
 import logging
-from .utils import ProxyLogHandler
+
+
+class ProxyLogHandler(logging.Handler):
+    def __init__(self, logger):
+        logging.Handler.__init__(self)
+        self.__logger = logger
+
+    def emit(self, record):
+        self.__logger.handle(record)
 
 listener = None
 

diff --git a/django_medusa/utils.py b/django_medusa/utils.py
@@ -1,13 +1,15 @@
 import imp
 from django.conf import settings
 from importlib import import_module
-import logging
 import sys
 
+from .log import get_logger
+
 
 def get_static_renderers():
     module_name = 'renderers'
     renderers = []
+    logger = get_logger()
 
     modules_to_check = []
 
@@ -33,34 +35,27 @@ def get_static_renderers():
             import_module(app)
             app_path = sys.modules[app].__path__
         except AttributeError:
-            print "Skipping app '%s'... (Not found)" % app
+            logger.error("Skipping app '%s'... (Not found)", app)
             continue
         try:
             imp.find_module(module_name, app_path)
         except ImportError:
-            print "Skipping app '%s'... (No 'renderers.py')" % app
+            logger.info("Skipping app '%s'... (No 'renderers.py')", app)
             continue
         try:
             app_render_module = import_module('%s.%s' % (app, module_name))
             if hasattr(app_render_module, "renderers"):
                 renderers += getattr(app_render_module, module_name)
             else:
-                print "Skipping app '%s'... ('%s.renderers' does not contain "\
-                      "'renderers' var (list of render classes)" % (app, app)
+                logger.error("Skipping app '%s'... "
+                             "('%s.renderers' does not contain "
+                             "'renderers' var (list of render classes)",
+                             app, app)
         except AttributeError:
-            print "Skipping app '%s'... (Error importing '%s.renderers')" % (
-                app, app
-            )
+            logger.error("Skipping app '%s'... (Error importing "
+                         "'%s.renderers')", app, app,
+                         exc_info=True)
             continue
-        print "Found renderers for '%s'..." % app
+        logger.info("Found renderers for '%s'...", app)
     print
     return tuple(renderers)
-
-
-class ProxyLogHandler(logging.Handler):
-    def __init__(self, logger):
-        logging.Handler.__init__(self)
-        self.__logger = logger
-
-    def emit(self, record):
-        self.__logger.handle(record)