WIP: Enabling forValue to generate named record types

[pleszczy]

No description provided.

[mtth]

Thanks for the PR @pleszczy. This is a nice idea but we will need a more involved change to support it (see inline comment).

PS: I updated the title of the PR to be more accurate since forValue already parses TypeScript objects, generating anonymous types for them. Let me know if I'm misunderstanding.

[mtth]

This won't work unfortunately: inferring a type from any value which reuses a constructor will fail (a type with the same name will be defined twice). For example, this will often happen when inferring array types.

class Foo {
  constructor(val) { this.value = val; }
}

const type = avro.Type.forValue([new Foo(1), new Foo(2)]); // Will throw.

One option could be to add a unique ID inside each name (e.g. generating Foo.g1, Foo.g2, ...), update combineObjects to use it, then do a final pass on the outermost type to combine all generated types from the same constructor and strip the ID.

For backwards compatibility, we should also guard it with an option, say useConstructorNames.

[pleszczy]

Hello mtth,
Sorry about that PR, I was just experimenting on my fork and didn't mean to make it towards the upstream master. Still thank you very much for the input, that s a pretty good idea.