Skip to content
This repository has been archived by the owner on Jun 22, 2022. It is now read-only.

Add support to paste after close, when emoji is copied #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

krolow
Copy link
Contributor

@krolow krolow commented Dec 26, 2016

It adds support to automatic paste in the old focus after "copy" from mojibar.

I have tested it in linux together with #78

Not sure if it works in mac as I don't have one to test, but I think it might be related to #23 #58 #16 ... if someone can test it in mac let me know if it works...

If you have already run npm install its necessary to rebuild electron install as robot is a native extension.. to rebuild do: npm rebuild --runtime=electron --target=1.4.0 --disturl=https://atom.io/download/atom-shell --abi=48

The solution is wait a bit the window be hide and then focus get back to the old open window, and so it sends the paste command.

@krolow krolow changed the title Add support to paste after close when copy Add support to paste after close, when emoji is copied Dec 26, 2016
@ghostlandr
Copy link

Sadly this still won't fix those issues, since focus doesn't return to the old open window on macOS 😭

@krolow
Copy link
Contributor Author

krolow commented Feb 1, 2017

i have been using in linux and its working like a charm here, I could not test in win/mac 😞

@ghostlandr
Copy link

Sorry, didn't mean to imply that it wouldn't. It's just that it sadly won't fix #23 et al :(

@denistsoi
Copy link

Seems to be working on mac -> selected emoji is copied to clipboard and pastes after close

@patricknelson
Copy link
Contributor

FYI, for those of you worried about focus, could you please take a look at #87 to see if that helps? For some reason it works well for me at least in Windows 10. Mac 🍎 is the only one I'm not so sure about.

@patricknelson
Copy link
Contributor

patricknelson commented Feb 18, 2017

Also: I think this should be a preference. That is, you should have a choice of one of the following, either:

  1. You select an emoji to copy, or
  2. You select an emoji to insert

When inserting, I don't think it's useful for it to utilize the clipboard unless there's no way around it. In fact, this could cause more issues if it because the default action as it may lead users on (initially, if they're unfamiliar with it) to think that the emoji is just being inserted and not clobbering their clipboard contents.

Just 🥓 for thought 😄

p.s. edit: When in the "insert" mode, I think copying should still be possible (via ctrl/cmd+c).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants