-
-
Notifications
You must be signed in to change notification settings - Fork 125
Better windows compatibility. #86
base: master
Are you sure you want to change the base?
Conversation
… compatibility. Also adding title to hint user about keywords and copied. Added yarn since it's hella fast 😺
…orrected systray transparency (on Win it can be dark) and added ability to center window on when loading.
NOTE: Had an issue with the dashed versions not working. Turns out those are ones without any sort of actual unicode but still have an alias, so I'm fixing this too |
…ent, automatically using :name: instead.
… of rendering, which is separate and only reduces based on search result.
Thanks for putting in all these work!
This is probably related to #8. The
I'd prefer if this is either an option or flagged for Windows only.
Nice touch! ❤️ |
@muan Nope, actually I believe it works fine without the I'm registering a level of discomfort with standardizing the icons across both OS's, is that correct? If so I can understand since it seems like a drastic change due to the level of native support in the mighty OSX. I like the idea of the app having a consistent appearance across all OS's using standardized icons, as it is already understood that even in Windows why the app itself may not display an emoji, it may still display just fine in Twitter (due to their shims) or in Github (due to Chrome/Chromium/Electron/Webkit still supporting it or via more shims) and it is known that it will also display differently depending on OS. At least the screen shots/demos displayed would be consistent with user experience regardless of OS, and I think that is a plus. But that's just me and that's my [albeit potentially weak] argument for it. |
# Conflicts: # .editorconfig # app/style.css # index.js
Also just resolved some merge conflicts against
Let me take a look at your focus related question in #85 while I'm still in here. |
@muan I can rebase & resolve conflicts... would you be willing to merge this soon? Any comment? It has sat for a while 😔 |
What is blocking the merge (except the conflicts)? |
That was my main aprehension with resolving the conflicts (which should be easy, haven't checked yet). I didn't want to resolve and have it continue to rot again. SIDE NOTE: I still use this daily 🎉 |
Also using it daily for nearly one year 🎉 |
Setup to help address #14.
Changes (copied from issue):
ctrl + shift
in place ofcommand
only for the preferences window (,
) and quitting (q
) and using Windows version of DevTools keyboard shortcut (Control+Shift+I
).yarn.lock
lock file, 'cause: shit's fast, yo! 🐱topRight
, however!Here is a demo before/after for the icon (you'll see why I changed it):
Before:
After:
Demo: