New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow diamondCut to be extended in a derived facet #13

Open

amarinkovic wants to merge 2 commits into mudgen:main from nayms:main

amarinkovic commented Sep 11, 2024 •

edited

Loading

Adding here the same change that was introduced recently in the diamond-2 repo

This PR updates the visibility of the diamondCut method in DiamondCutFacet from external to public and adds the virtual keyword. This change enables the method to be overridden and extended in a derived facet.

amarinkovic added 2 commits

December 28, 2023 16:27


          refactor(cut): update visibility to allow extension

01056ed


          Merge pull request #1 from mudgen/main

0cac678

Upstream 0byte/payable selector bugfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet