Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: sort tag list when load tags #224

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

cybaj
Copy link

@cybaj cybaj commented Nov 25, 2024

added sorting tag list when writing note

@mudkipme
Copy link
Owner

The tag list is sorted with localizedCaseInsensitiveCompare at https://github.com/mudkipme/MoeMemos/blob/main/MoeMemos/Model/NestedTag.swift#L39

Did you encounter any issues with tag list sorting?

@cybaj
Copy link
Author

cybaj commented Dec 23, 2024

Ah, okay. The PR includes two sorting about root tags and these nested ones.

Yes. When I add tag to a memo, the tag list shows up not sorted.
In the code you mentioned, I think that the sorting is applied to nested ones, not root tags.

Sorting the root tags list quite is useful to someone uses a long tag list like me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants