Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Service Wiring / Concurrency pt 1 #2474

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

dave-gray101
Copy link
Collaborator

@dave-gray101 dave-gray101 commented Jun 3, 2024

This PR is the start of transitioning our core services to the core/application.go \ core/startup model.
In order to keep things reviewable, this PR will have a limited scope - rather than moving everything at once, my goal is to select services that are covered by existing tests for the detection of regressions. Therefore, this PR contains the following components:

  • begins the creation of http/middleware, migrating request object handling outside the endpoints themselves.
    • also takes over some existing middleware to this new folder, for organizational reasons.
    • Does transition openai endpoints to use the common model middleware - this should help test coverage
  • Finishes up service wiring infrastructure in core/startup
  • pkg/concurrency - basic JobResult structure
  • Port over TTS Endpoints to TextToSpeechBackendService
  • Port over Embedding Endpoint to EmbeddingBackendService

Squashing again, the middleware approach is much more sustainable.

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for localai ready!

Name Link
🔨 Latest commit 563a416
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/66725a730eedf80008f34149
😎 Deploy Preview https://deploy-preview-2474--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Dave Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant