feat(backends): Drop bert.cpp #4272
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mudler
force-pushed
the
drop/bert.cpp
branch
from
a2d95ae
to
62a1e4e
Compare
use llama.cpp 3.2 as a drop-in replacement for bert.cpp Signed-off-by: Ettore Di Giacinto <[email protected]>
mudler
force-pushed
the
drop/bert.cpp
branch
from
62a1e4e
to
02ddd44
Compare
dave-gray101
previously approved these changes
Nov 26, 2024
Signed-off-by: Ettore Di Giacinto <[email protected]>
mudler
force-pushed
the
drop/bert.cpp
branch
from
81e6de5
to
49db0fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR drops the
bert-cppbackend entirely, as nowadays llama.cpp can be used as embeddings backend with higher accuracy and also it is much more faster in terms of speedup.This PR also silently moves the model galleries and the examples referencing the bert-embeddings model to a llama3.2 based version.
Notes for Reviewers
Signed commits