Cloud agnostic logger #3

andrei-kalashnikov · 2025-06-11T08:36:38Z

No description provided.

coderabbitai · 2025-06-11T08:36:44Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-06-11T08:43:22Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

andrei-kalashnikov · 2025-06-11T08:46:46Z

Project Structure and Configuration

Added comprehensive test coverage with pytest framework
Introduced Taskfile for development workflow automation
Added GitHub Actions CI/CD pipeline for PR validation
Added Poetry configuration for dependency management
Configured coverage reporting with codecov integration

Formatter Architecture Refactoring

Split formatter into two classes: StandardJSONFormatter and GoogleCloudFormatter
Created universal JSON formatter that works with any logging system
Maintained Google Cloud specific formatter as extension of standard formatter
Added configurable LOG_FORMATTER_CLASS setting for formatter selection
Improved field mapping and trace correlation for Google Cloud Logging

Middleware Improvements

Renamed SetRequestToLoggerMiddleware to LogRequestAndResponseMiddleware
Created separate SetUserContextMiddleware for user context management
Enhanced request/response data processing and masking
Improved error handling and logging throughout middleware chain
Added support for GraphQL context through GrapheneSetUserContextMiddleware

Data Processing Enhancements

Improved sensitive data masking with configurable styles
Enhanced data abridging for long strings, lists, and deep nested objects
Better handling of request bodies with different content types
Added support for multipart form data logging
Improved JSON parsing and error handling

Testing Infrastructure

Added comprehensive test suite covering all major functionality
Created fixtures for testing different request types and scenarios
Added tests for formatter behavior with and without context
Implemented middleware testing with mocked dependencies
Added tests for sensitive data masking and data abridging

Documentation Updates

Updated README with new formatter configuration examples
Added documentation for both standard JSON and Google Cloud formatters
Improved installation and configuration instructions
Added examples for different logging scenarios
Updated badges and project metadata

Settings and Configuration

Added new configuration options for formatter selection
Maintained backward compatibility for existing settings
Improved default values and validation
Enhanced configuration flexibility for different deployment scenarios
Added support for custom user field mapping

Code Quality Improvements

Added type hints throughout the codebase
Implemented comprehensive linting with Ruff
Added mypy static type checking
Improved code organization and module structure
Enhanced error handling and logging practices

eldiiar-egem · 2025-06-11T09:41:59Z

I thought it was going to be a different repo. Now, that the functionality has changed, the repository name is wrong. How do you intended to proceed?

eldiiar-egem · 2025-06-11T09:44:58Z

README.md

+            "django": {
+                "handlers": [env.str("DJANGO_LOG_HANDLER", "json-handler")],
+                "level": env.str("DJANGO_LOG_LEVEL", "INFO"),
+                "propagate": False,
+            },
+            "django.server": {
+                "handlers": [env.str("DJANGO_LOG_HANDLER", "json-handler")],
+                "level": env.str("DJANGO_SERVER_LEVEL", "ERROR"),
+                "propagate": False,
+            },
+            "django.request": {
+                "handlers": [env.str("DJANGO_LOG_HANDLER", "json-handler")],
+                "level": env.str("DJANGO_REQUEST_LEVEL", "ERROR"),
+                "propagate": False,
+            },


Thinking further, I want to use a common logger for VarioSystems FastAPI project. Is it compatible?

eldiiar-egem · 2025-06-11T09:45:55Z

poetry.lock

@@ -0,0 +1,670 @@
+# This file is automatically @generated by Poetry 2.1.2 and should not be changed by hand.


How about moving to uv?

andrei-kalashnikov added 12 commits June 10, 2025 14:38

Dependencies update, configuration fix, tests basics

20d9996

Formatter fixes

27f2be7

Mypy issues fix

e59cc9d

Refactoring

fe93449

Test for middleware

43b3f9b

Tests for LogRequestAndResponseMiddleware

1df7957

Tests for GrapheneSetUserContextMiddleware

129c416

Tests for formatters

fb04baa

mypy fixes, polishing

2a37aab

mypy fixes, polishing

b493cdc

mypy fixes, polishing

2e8b055

Readme fixes, pr validation pipeline

c3a0bb0

andrei-kalashnikov self-assigned this Jun 11, 2025

Python version up for configs, pipelines fixes

ee61074

Taskfile fix

c990f60

Cleanup

5cdb716

andrei-kalashnikov requested a review from eldiiar-egem June 11, 2025 09:00

eldiiar-egem reviewed Jun 11, 2025

View reviewed changes

eldiiar-egem approved these changes Jun 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Cloud agnostic logger #3

Cloud agnostic logger #3

Uh oh!

andrei-kalashnikov commented Jun 11, 2025

Uh oh!

coderabbitai bot commented Jun 11, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Jun 11, 2025

Uh oh!

andrei-kalashnikov commented Jun 11, 2025 •

edited

Loading

Uh oh!

eldiiar-egem commented Jun 11, 2025

Uh oh!

eldiiar-egem Jun 11, 2025

Uh oh!

eldiiar-egem Jun 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,670 @@
		# This file is automatically @generated by Poetry 2.1.2 and should not be changed by hand.

Cloud agnostic logger #3

Are you sure you want to change the base?

Cloud agnostic logger #3

Uh oh!

Conversation

andrei-kalashnikov commented Jun 11, 2025

Uh oh!

coderabbitai bot commented Jun 11, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Jun 11, 2025

Welcome to Codecov 🎉

Uh oh!

andrei-kalashnikov commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Project Structure and Configuration

Formatter Architecture Refactoring

Middleware Improvements

Data Processing Enhancements

Testing Infrastructure

Documentation Updates

Settings and Configuration

Code Quality Improvements

Uh oh!

eldiiar-egem commented Jun 11, 2025

Uh oh!

eldiiar-egem Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

eldiiar-egem Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)

andrei-kalashnikov commented Jun 11, 2025 •

edited

Loading