Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run api tests ordering #556

Merged
merged 1 commit into from
Nov 18, 2023
Merged

fix: run api tests ordering #556

merged 1 commit into from
Nov 18, 2023

Conversation

YC
Copy link
Collaborator

@YC YC commented Nov 17, 2023

Reorder such that:

  1. Run old version (initialisation for old db)
  2. Run new version (migration test)
  3. If sqlite (api tests)
    1. populate data
    2. Run new version again
    3. Run api test

@YC YC force-pushed the fix/run-tests-script branch 3 times, most recently from 75ef68b to dec06fa Compare November 17, 2023 23:06
@YC YC changed the title fix: run api tests ordering fix: run api tests ordering (WIP) Nov 17, 2023
@YC YC force-pushed the fix/run-tests-script branch from dec06fa to 4bdc4e6 Compare November 17, 2023 23:13
@YC YC changed the title fix: run api tests ordering (WIP) fix: run api tests ordering Nov 17, 2023
@YC YC requested a review from muety November 17, 2023 23:16
@muety
Copy link
Owner

muety commented Nov 18, 2023

Thank you! 🙌 🙏

Briefly for my understanding: tests were failing recently, because we tried to run the API tests against the old release, which obviously didn't have the latest changes included, that we asserted in those tests? Correct?

@muety muety merged commit b79e5ca into master Nov 18, 2023
12 checks passed
@YC
Copy link
Collaborator Author

YC commented Nov 18, 2023

Yes, that's correct.

@YC YC deleted the fix/run-tests-script branch November 18, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants