Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tab switching issue #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

zainniazi
Copy link

  • Order doesn't have value above Xamarin 4.3.0.991221, which doesn't change the tabs

- Order doesn't have value above Xamarin 4.3.0.991221, which doesn't change the tabs
@zainniazi
Copy link
Author

@muhaym can you please have a look ?
we are using this plugin and it doesn't work if we update to latest versions of xamarin

@muhaym
Copy link
Owner

muhaym commented Mar 14, 2020

@zainniazi I'm not in a position to check the compatibility now, though Does the change support previous versions of Xamarin Forms?
Is there any Xamarin Forms issue you can link to about the sudden change of Order and Item Id?

- Xamarin updates
- Code refactoring
@zainniazi
Copy link
Author

@muhaym I was unable to find anything on Order but i did see the Renderer from Xamarin Android and they are using ItemId

Here:
https://github.com/xamarin/Xamarin.Forms/blob/1532d46f5fb6f219594015b80f8e5a2476512882/Xamarin.Forms.Platform.Android/AppCompat/TabbedPageRenderer.cs#L859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants