Migrate to AndroidX #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xamarindevelopervietnam Thanks for the PR, have added some comments, please check |
|
Hi @muhaym, i didn't see any comment. |
muhaym
requested changes
Apr 13, 2020
| using Xamarin.Forms; | ||
| using Android.Support.Design.BottomNavigation; | ||
| using Google.Android.Material.BottomNavigation; |
There was a problem hiding this comment.
https://github.com/xamarin/Xamarin.Forms/blob/7a52542d50797ccc69ae1d8dd84259190d96bdb4/Xamarin.Forms.Platform.Android/AppCompat/TabbedPageRenderer.cs#L10
Use compiler directive approach for providing support for previous versions too
eg. #if ANDROID_29
| @@ -70,7 +68,7 @@ private void UpdateIcons(int selectedIndex) | |||
| var icon = Transforms.GetSelectedIcon(page); | |||
| if (string.IsNullOrWhiteSpace(icon)) | |||
| { | |||
| menu.GetItem(i).SetIcon(IdFromTitle(page.IconImageSource ?? page.Icon, ResourceManager.DrawableClass)); | |||
| menu.GetItem(i).SetIcon(IdFromTitle(page.IconImageSource ?? page.IconImageSource, ResourceManager.DrawableClass)); | |||
There was a problem hiding this comment.
I don't understand why you did this change. If IconImageSource is already set, it will be taken, then page.Icon.
Forgot to Submit Review :D, Added Now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to AndroidX