-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Menu] Overhaul the component API #468
Conversation
Bug when traversing back to the submenu trigger, menu doesn't open Screen.Recording.2024-07-25.at.11.33.36.PM.mov |
@michaldudak Feedback based on our chat:
|
@colmtuite I did 1 and 2. |
@michaldudak In this vid, the menu is initially opening above the trigger, then quickly repositioning itself below. |
@atomiks, Should be working OK now.
@colmtuite, could you prepare a reproduction on codesandbox? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Closes #214
Closes #9
Closes #46
Closes #63
Closes #411
Preview
https://deploy-preview-468--base-ui.netlify.app/base-ui/react-menu/
To do
transitionDuration
CSS property is used #9keepMounted
propIn separate PRs