Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Copy supporting files from the Core repository #6

Merged
merged 37 commits into from
Feb 27, 2024

Conversation

michaldudak
Copy link
Member

Copied all the files needed to run the docs site, tests, and supporting scripts.

The docs contain only the Base UI pages. All the others were removed. There may still be several unused components there.

Where possible, infra packages are referenced through npm. One notable exception is api-docs-builder, which hasn't been converted to a package yet. It is referenced through the Git repo (similarly to how it's done in MUI X and Toolpad).

Some of the scripts and config files use the Core monorepo Git dependency as well.

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 1c37ac5
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/65dde502a2b0c10008296714
😎 Deploy Preview https://deploy-preview-6--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@michaldudak michaldudak added the core Infrastructure work going on behind the scenes label Feb 26, 2024
@colmtuite
Copy link
Contributor

colmtuite commented Feb 27, 2024

I just noticed the following that we chatted about:

  • Marketing site is unfinished with broken buttons/links
  • Interactive component demos don't work
  • Docs sidebar accordion menus are missing animation/transition
  • Docs header product switcher is broken

@michaldudak
Copy link
Member Author

The Netlify redirects were not set up correctly. It should work well now.

@mnajdova
Copy link
Member

Is it intentional that the docs "Base UI" link looks like this?
Screenshot 2024-02-27 at 14 01 15

Some images are broken, e.g.
https://deploy-preview-6--base-ui.netlify.app/base-ui/getting-started/support/#bug-reproductions

Screenshot 2024-02-27 at 14 03 53

I can't finish reviewing later today.

@michaldudak
Copy link
Member Author

michaldudak commented Feb 27, 2024

The link looks the same as on the Material UI site: https://mui.com/base-ui/. As we are in the Base UI section, the link is highlighted.

As a side note, I don't think we'll replace the Base UI subsite on mui.com with these docs anytime soon. I'd wait until we have a consistent API across all components and then release a package and new docs. For now, we'll be able to access it via https://master--base-ui.netlify.com


I fixed the broken images.

@colmtuite
Copy link
Contributor

All header navigation links are broken except Base UI. Everything else seems ok so far.

@michaldudak
Copy link
Member Author

That's kind of expected (and consistent with how previews of other subsites like MUI X work). Links will work when the site is integrated into the MUI site.

@michaldudak michaldudak merged commit abeee0e into mui:master Feb 27, 2024
9 checks passed
@michaldudak michaldudak deleted the copy-core-files branch February 27, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants