-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Copy supporting files from the Core repository #6
Conversation
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I just noticed the following that we chatted about:
|
The Netlify redirects were not set up correctly. It should work well now. |
Is it intentional that the docs "Base UI" link looks like this? Some images are broken, e.g. I can't finish reviewing later today. |
The link looks the same as on the Material UI site: https://mui.com/base-ui/. As we are in the Base UI section, the link is highlighted. As a side note, I don't think we'll replace the Base UI subsite on mui.com with these docs anytime soon. I'd wait until we have a consistent API across all components and then release a package and new docs. For now, we'll be able to access it via https://master--base-ui.netlify.com I fixed the broken images. |
All header navigation links are broken except Base UI. Everything else seems ok so far. |
That's kind of expected (and consistent with how previews of other subsites like MUI X work). Links will work when the site is integrated into the MUI site. |
Copied all the files needed to run the docs site, tests, and supporting scripts.
The docs contain only the Base UI pages. All the others were removed. There may still be several unused components there.
Where possible, infra packages are referenced through npm. One notable exception is api-docs-builder, which hasn't been converted to a package yet. It is referenced through the Git repo (similarly to how it's done in MUI X and Toolpad).
Some of the scripts and config files use the Core monorepo Git dependency as well.