Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Rename data-state to data-component #638

Closed
wants to merge 6 commits into from

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Sep 19, 2024

Closes #521

@atomiks atomiks added the core Infrastructure work going on behind the scenes label Sep 19, 2024
@atomiks atomiks marked this pull request as draft September 19, 2024 07:06
@mui-bot
Copy link

mui-bot commented Sep 19, 2024

Netlify deploy preview

https://deploy-preview-638--base-ui.netlify.app/

Generated by 🚫 dangerJS against 894e8b0

@atomiks atomiks marked this pull request as ready for review September 19, 2024 08:32
@@ -57,7 +57,7 @@ const ProgressRoot = React.forwardRef(function ProgressRoot(
direction,
max,
min,
state: progress.state,
progress: progress.state,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @mj12albert - this is ok?

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 19, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 19, 2024
@colmtuite colmtuite requested a review from vladmoroz September 19, 2024 14:21
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 2, 2024
@atomiks
Copy link
Contributor Author

atomiks commented Oct 8, 2024

Changed in #717

@atomiks atomiks closed this Oct 8, 2024
@atomiks atomiks deleted the refactor/data-state branch October 8, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] Rename "state" style hooks
3 participants