Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[popups] Use data-anchor-hidden attribute #934

Merged
merged 6 commits into from
Dec 4, 2024
Merged

[popups] Use data-anchor-hidden attribute #934

merged 6 commits into from
Dec 4, 2024

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Dec 2, 2024

hideWhenDetached -> always-present data-anchor-hidden attribute

@atomiks atomiks added the core Infrastructure work going on behind the scenes label Dec 2, 2024
@mui-bot
Copy link

mui-bot commented Dec 2, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-934--base-ui.netlify.app/

Generated by 🚫 dangerJS against 1877950

@vladmoroz
Copy link
Contributor

Not a strong opinion, but should we consider data-trigger-hidden? Kind of how data-popup-open on triggers references the Popup part.

@vladmoroz
Copy link
Contributor

Although we do --anchor-width, --anchor-height. Maybe that's another term that can be replaced with "trigger", but we probably can discuss it later

@atomiks atomiks merged commit b64e1dd into mui:master Dec 4, 2024
23 checks passed
@atomiks atomiks deleted the refactor/data-anchor-hidden branch December 4, 2024 23:44
@atomiks
Copy link
Contributor Author

atomiks commented Dec 4, 2024

Although we do --anchor-width, --anchor-height. Maybe that's another term that can be replaced with "trigger", but we probably can discuss it later

The anchor can be a custom element not just the trigger (that's the default though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladmoroz vladmoroz vladmoroz approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak is a code owner

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atomiks @mui-bot @vladmoroz