Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Positioner] Support logical values for side prop #950

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

[Positioner] Support logical values for side prop #950

wants to merge 12 commits into from
+1,120 −365

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Dec 4, 2024 •
edited
Loading

@mj12albert mj12albert added the component: menu This is the name of the generic UI component, not the React module! label Dec 4, 2024
@mui-bot
Copy link

mui-bot commented Dec 4, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-950--base-ui.netlify.app/

Generated by 🚫 dangerJS against ce7f340

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 4, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 4, 2024
@mj12albert mj12albert force-pushed the feat/logical-side branch 2 times, most recently from 4d5c396 to 34f64d6 Compare December 4, 2024 15:01
@mj12albert mj12albert added component: select This is the name of the generic UI component, not the React module! component: tooltip This is the name of the generic UI component, not the React module! component: popover The React component. component: preview card The React component. labels Dec 4, 2024
@mj12albert mj12albert changed the title feat/logical-side [Positioner] Support logical values side prop Dec 4, 2024
@mj12albert mj12albert changed the title [Positioner] Support logical values side prop [Positioner] Support logical values for side prop Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiks atomiks Awaiting requested review from atomiks atomiks will be requested when the pull request is marked ready for review atomiks is a code owner

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite will be requested when the pull request is marked ready for review colmtuite is a code owner

@michaldudak michaldudak Awaiting requested review from michaldudak michaldudak will be requested when the pull request is marked ready for review michaldudak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: menu This is the name of the generic UI component, not the React module! component: popover The React component. component: preview card The React component. component: select This is the name of the generic UI component, not the React module! component: tooltip This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Positioner] Support logical side prop
2 participants
@mj12albert @mui-bot