Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Progress][Slider] Add format prop #962

Closed
wants to merge 3 commits into from

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Dec 5, 2024

Part of #961

  • Adds a format: Intl.NumberFormatOptions prop on ProgressRoot and SliderRoot

  • Range sliders optionally accepts format as an array to format different values differently

  • I have followed (at least) the PR section of the contributing guide.

@mj12albert mj12albert added component: slider This is the name of the generic UI component, not the React module! component: progress This is the name of the generic UI component, not the React module! labels Dec 5, 2024
@mui-bot
Copy link

mui-bot commented Dec 5, 2024

Netlify deploy preview

https://deploy-preview-962--base-ui.netlify.app/

Generated by 🚫 dangerJS against c58b56a

@mj12albert mj12albert force-pushed the feat/format-range-widgets branch from 14834cd to 5870470 Compare December 5, 2024 09:43
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 6, 2024
@mj12albert mj12albert force-pushed the feat/format-range-widgets branch from 5870470 to 2bbea53 Compare December 6, 2024 13:03
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 6, 2024
@mj12albert mj12albert force-pushed the feat/format-range-widgets branch from 2bbea53 to c58b56a Compare December 6, 2024 14:54
@mj12albert mj12albert closed this Dec 9, 2024
@mj12albert
Copy link
Member Author

Split into:
#989
#990

@mj12albert mj12albert deleted the feat/format-range-widgets branch December 9, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: progress This is the name of the generic UI component, not the React module! component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants