[core] Fix running mocha related scripts on Windows locally #44664
Conversation
Netlify deploy previewhttps://deploy-preview-44664--material-ui.netlify.app/ Bundle size report |
mj12albert
changed the title
|
Hey thanks for contributing @ChristopherJamesL ~ I'm not really a windows user, just gotta wait for another reviewer to have a look |
CONTRIBUTING.md
Outdated
| If you encounter error: `'m)[jt]s?' is not recognized as an internal or external command` while running `pnpm test:unit`, it is likely because of an issue with how the test file extensions are handled in the script. Solution: Modify the `nx_test_unit` script in the root `package.json` to | ||
| `"nx_test_unit": "cross-env NODE_ENV=test mocha 'packages/**/*.test.{js,jsx,ts,tsx}' 'packages-internal/**/*.test.{js,jsx,ts,tsx}' 'docs/**/*.test.{js,jsx,ts,tsx}'"` This change ensures that the test files are correctly recognized with the appropriate extensions and allows running tests using the `--grep` flag on Windows. |
There was a problem hiding this comment.
I haven't looked close, but at first sight, this can't fly, we can't possibly ask Windows contributors to change the source to run the tests, it's horrible DX.
Can we instead change the script source?
Either this was broken in #44143 or it's mochajs/mocha#5219. I can't easily test this on Windows.
There was a problem hiding this comment.
Yea I understand. I tried to look further into it to see if I could have a command that runs the tests successfully on both windows and mac but I wasn't able to find one.
There was a problem hiding this comment.
I am a Windows user, adding double quotes works, as shown in mochajs/mocha#5219. For example:
--- a/package.json
+++ b/package.json
@@ -95,7 +95,7 @@
"nx_test_karma": "cross-env NODE_ENV=test karma start test/karma.conf.js",
"nx_test_regressions_run": "mocha --config test/regressions/.mocharc.js --delay 'test/regressions/**/*.test.js'
",
"nx_test_regressions_pigment_css_run": "mocha --config apps/pigment-css-vite-app/.mocharc.cjs --delay 'apps/pig
ment-css-vite-app/**/*.test.js'",
- "nx_test_unit": "cross-env NODE_ENV=test mocha 'packages/**/*.test.?(c|m)[jt]s?(x)' 'packages-internal/**/*.tes
t.?(c|m)[jt]s?(x)' 'docs/**/*.test.?(c|m)[jt]s?(x)'"
+ "nx_test_unit": "cross-env NODE_ENV=test mocha \"packages/**/*.test.?(c|m)[jt]s?(x)\" \"packages-internal/**/*.
test.?(c|m)[jt]s?(x)\" \"docs/**/*.test.?(c|m)[jt]s?(x)\""
},
"dependencies": {
"@googleapis/sheets": "^9.3.1",@ChristopherJamesL Can you try the change and confirm? It needs to be applied to other scripts too.
oliviertassinari
added
test
and removed
docs
oliviertassinari
changed the title
ZeeshanTamboli
changed the title
There was a problem hiding this comment.
@ChristopherJamesL I updated the scripts. They work on Windows OS now.
@mj12albert Can you check if the changes work on Max OS X as well?
Thanks @ZeeshanTamboli they do ~ I noticed there's also |
@mj12albert They do work in single quotes on Windows OS as well. The glob pattern of asterisks ( |
I added documentation for the purpose of helping developers run unit tests if they are on a windows machine.