-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tooltip] Fix tooltip arrow css var background #33753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for the fix!
Even though, the Tooltip
background is alpha(palette.grey[700], 0.92))
but I'd say that your fix makes more sense.
Trying to get the back ground |
Sorry, I don't quite get it. Can you share the minimal reproduction via a CodeSandbox? |
Ah, I see. This is a bug because there is no // TooltipArrow
color: theme.vars
? `rgba(${theme.vars.palette.grey.darkChannel} / 0.9)`
: alpha(theme.palette.grey[700], 0.9), |
@TimoWilhelm Are you using CSS variables in your project? Would love to hear your feedback about the overall experience. |
Thanks for the quick PR review @siriwatknp. Yep, I used CSS variables since it became available and my experience has been really positive so far. I strongly believe this is the future of the library. My favorite features are avoiding the color-scheme flash with SSR and preventing any hydration mismatch errors. I haven't found a nice way yet to access the CSS variables for styling beyond components (e.g. global scrollbar track/thumb) and I wish the CSP hash for the |
Thanks for sharing! |
This PR fixes the Tooltip arrow background color, to use the same color as the tooltip if CSS variables are used.