[docs][material-ui] Add script to generate template screenshots #42903
Conversation
siriwatknp
added
docs
Netlify deploy previewhttps://deploy-preview-42903--material-ui.netlify.app/ Bundle size report |
| @@ -60,7 +60,9 @@ function ToggleCustomTheme({ showCustomTheme, toggleCustomTheme }) { | |||
| <AutoAwesomeRoundedIcon sx={{ fontSize: '20px', mr: 1 }} /> | |||
| Custom theme | |||
| </ToggleButton> | |||
| <ToggleButton value={false}>Material Design 2</ToggleButton> | |||
| <ToggleButton id="toggle-default-theme" value={false}> | |||
There was a problem hiding this comment.
I'm wondering if id="toggle-default-theme" could confuse new user, thinking this id has an impact on the theme
| <ToggleButton id="toggle-default-theme" value={false}> | |
| <ToggleButton data-screen-shots="toggle-default-theme" value={false}> |
There was a problem hiding this comment.
That's a lot better. I changed to data-screenshot="toggle-mode" and data-screenshot="toggle-default-theme".
| // eslint-disable-next-line no-console | ||
| console.log(error); | ||
| } |
There was a problem hiding this comment.
Not sure it changes something
| // eslint-disable-next-line no-console | |
| console.log(error); | |
| } | |
| // eslint-disable-next-line no-console | |
| console.error(error); | |
| } |
| href: '/material-ui/getting-started/templates/dashboard/', | ||
| source: `${sourcePrefix}/docs/data/material/getting-started/templates/dashboard`, | ||
| hasDarkMode: true, |
There was a problem hiding this comment.
Should it also get a hasDefault to allow showing images with -default.jpg and -default-dark.jpg ?
There was a problem hiding this comment.
I think that'd be overkill for now. It can be a separate PR but need help from @zanivan to find a good DX to show between custom/default with light/dark.
There was a problem hiding this comment.
I plan to use the default image in a blog post (separate PR), that's the reason I added it.
Part of #41469
Motivation
Reduce manual work to update the screenshots when code changes.
The script is for local use, not intend to run on CI.
Further improvements