Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Remove esmExternals from the docs #43068

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from
Draft

[docs] Remove esmExternals from the docs #43068

wants to merge 22 commits into from
+304 −278

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jul 25, 2024 •
edited
Loading

Remove esmExternals by adding exports to X packages package.json: mui/mui-x#14386

See #30671 (comment)

To Do

  • Investigate why the regression tests are breaking. Looks like an X package trying to import a CJS package.

@Janpot Janpot added scope: docs-infra Specific to the docs-infra product docs Improvements or additions to the documentation labels Jul 25, 2024
@mui-bot
Copy link

mui-bot commented Jul 25, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43068--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 5ab86e1

@DiegoAndai
Copy link
Member

This might be helpful: vercel/next.js#65056 (comment)

@Janpot Janpot mentioned this pull request Jul 29, 2024
Merged
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 31, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 28, 2024
@Janpot Janpot changed the title [docs] Investigate removing esmExternals (WIP) [docs] Remove esmExternals from the docs Aug 30, 2024
@Janpot Janpot mentioned this pull request Aug 31, 2024
Draft
13 tasks
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 2, 2024
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Sep 2, 2024
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation PR: out-of-date The pull request has merge conflicts and can't be merged scope: docs-infra Specific to the docs-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Janpot @mui-bot @DiegoAndai