-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Add exports field to packages #43521
Conversation
Netlify deploy previewBundle size reportBundle size will be reported once CircleCI build #742065 finishes. |
@Janpot I'm testing #41596 (comment). Initially the issue doesn't seem to be fixed by removing the internal package.json files. I'm doing the same test we did a few months back:
Interestingly, back then, I'll do a debugging session, but I'm letting you know in case you want to test it on your side in the meantime. |
@DiegoAndai I'v been working on this over the past week in
I've extracted some of the issues that popped up as they can be released separately:
I followed your steps to reproduce with the following dependencies: "@mui/icons-material": "https://pkg.csb.dev/mui/material-ui/commit/d4953d45/@mui/icons-material",
"@mui/material": "https://pkg.csb.dev/mui/material-ui/commit/d4953d45/@mui/material",
"@mui/material-nextjs": "https://pkg.csb.dev/mui/material-ui/commit/d4953d45/@mui/material-nextjs", And both I'm still in the process of testing how X works but that looks promising so far. The one unknown I have left is whether I can remove |
Follow up on #41596 (comment). Draft to create CI builds to test with.
CC: @Janpot