[docs] Add scrollbar to color picker demo #43672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
docs
Netlify deploy previewhttps://deploy-preview-43672--material-ui.netlify.app/ Bundle size report |
Co-authored-by: Zeeshan Tamboli <[email protected]> Signed-off-by: sai chand <[email protected]>
ZeeshanTamboli
approved these changes
Sep 11, 2024
| @@ -58,7 +58,7 @@ function ColorDemo(props) { | |||
| </Typography> | |||
| </Toolbar> | |||
| </AppBar> | |||
| <Box component="pre" sx={{ m: 2, fontSize: 16 }}> | |||
| <Box component="pre" sx={{ m: 2, fontSize: 16, overflowX: 'auto' }}> | |||
There was a problem hiding this comment.
Why not
Suggested change
| <Box component="pre" sx={{ m: 2, fontSize: 16, overflowX: 'auto' }}> | |
| <Box component="pre" sx={{ m: 2, fontSize: 16, overflow: 'auto' }}> |
like in
?There was a problem hiding this comment.
We could do this. The reason I went for overflowX is that I haven't come across any situation that requires a scrollbar on the Y axis.
There was a problem hiding this comment.
Ok, we can be lazy and wait. It's more that I usually never seen X/Y overflow to be superior to the alternatives: what I found most useful is nothing, or overflow: auto when I want to make sure a scroll container trigger.
oliviertassinari
added
bug 🐛
This was referenced Oct 3, 2024
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added scroll bar to https://deploy-preview-43672--material-ui.netlify.app/material-ui/customization/color/#playground demo, so that users can see names of colors they have selected
current demo: https://mui.com/material-ui/customization/color/#playground