-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][mui-system] Simplify version prerelease export #43699
Conversation
Netlify deploy previewhttps://deploy-preview-43699--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
To consider at which point this should be added to the other packages, etc. If we consider that today we don't need this, and tomorrow we might, then the same reasoning applies to Base UI, Pigment CSS, etc.
Waiting for upvotes issue created mui/base-ui#599, maybe one day it will make sense there too. |
Follow up on #43190 (comment).
Replace
preReleaseLabel
andpreReleaseNumber
exports in favor ofprerelease
export, as this is simpler and we can save the bundle size.Not considering this a breaking change as these consts are only available on prerelease versions