Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve Toolpad Core docs #43796
[docs] Improve Toolpad Core docs #43796
Changes from 12 commits
cc061e5
bbdff62
6d30b3e
31932f9
3c41def
655ea3e
e55719c
eb195e8
0b7fe3f
92ba569
a111ee1
bf03532
46dcc36
794c4be
6936458
2faedd3
2e2052c
54cc265
79f374a
f19f2b6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dark/light mode is broken on all those demos.
As far as I understand things,
theme={demoTheme}
shouldn't be provided, not be theAppProvider
responsibility to have this. Imagine I already have an application configured with a theme, I want some of my pages to have a Toolpad container, this shouldn't break. I mean, https://marmelab.com/react-admin/Theming.html feels wrong, no?At minimum, MUI System should support theme nesting where you can inherit the light/dark mode and use different values for the other values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const demoWindow = window !== undefined ? window() : undefined;
feels confusing, I think it should copymaterial-ui/docs/data/material/components/app-bar/HideAppBar.js
Line 31 in a80eb39
to be clear.