[docs-infra] Upgrade next to v14.2.14 #43964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongarciah
commented
Oct 2, 2024
| @@ -56,7 +56,8 @@ export default withDocsInfra({ | |||
| // We only care about Node runtime at this point. | |||
| (options.nextRuntime === undefined || options.nextRuntime === 'nodejs') | |||
| ) { | |||
| const [nextExternals, ...externals] = config.externals; | |||
| const externals = config.externals.slice(0, config.externals.length - 2); | |||
| const nextExternals = config.externals.at(-1); | |||
There was a problem hiding this comment.
nextExternals is the last element in the array since Next.js v14.2.14
aarongarciah
changed the title
Janpot
reviewed
Oct 2, 2024
Merged
Netlify deploy previewhttps://deploy-preview-43964--material-ui.netlify.app/ Bundle size reportBundle size will be reported once CircleCI build #755879 finishes. |
|
Ouch, more problems after |
aarongarciah
force-pushed
the
next-14.2.14
branch
from
df97dca to
6c75573
Compare
1 task
|
This is fix is now part of #43555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next.js v14.2.14 introduced a change that broke our docs build. We discovered this after running
pnpm dedupein a release PR. See #43957 (comment) for more info.This change in Next.js was the culprit: https://github.com/vercel/next.js/pull/70382/files#diff-5f441142eb8ba9bcba515aa36fbc420a113307bd191e54a4e9e6c43529fc2613R861